-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add ValidatingAdmissionPolicy
to enforce package uniqueness across ClusterExtension
#774
✨ Add ValidatingAdmissionPolicy
to enforce package uniqueness across ClusterExtension
#774
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #774 +/- ##
=======================================
Coverage 67.16% 67.16%
=======================================
Files 22 22
Lines 1465 1465
=======================================
Hits 984 984
Misses 415 415
Partials 66 66
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
f17ff5e
to
55eab3e
Compare
Keeping this in draft for now. It seems like tilt job needs to be updated in addition to #771 |
5d45189
to
6537533
Compare
0951051
to
4cadf14
Compare
To enforce package uniqueness across `ClusterExtension` Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
This is a workaround for kustomize issue where it does not prefix `ValidatingAdmissionPolicy`'s name in `ValidatingAdmissionPolicyBinding`'s field `spec.policyName`. This results in manifests which can still be applied to a cluster, but the policy will not be working due to broken policy binding. These APIs are now stable in 1.30 so one might expect that Kustomize will eventually support these by default. If this happens - we will be able to remove this change. Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
4cadf14
to
e59ab41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
In a follow-up, could we add some tests?
Description
To enforce package uniqueness across
ClusterExtension
.We currently have this enforcement on the operator-controller level, but with Deppy removal in #758 we want to shift it into API server.
Reviewer Checklist